Adds the semantics role support #56318
Conversation
chunhtai
force-pushed
the
issues/157824
branch
from
af3ec9d to
833e74f
Compare
chunhtai
force-pushed
the
issues/157824
branch
from
833e74f to
512e56d
Compare
| /// The roles are translated into native accessibility roles in each platform. | ||
| enum SemanticsRole { | ||
| /// Does not represent any role. | ||
| none, |
There was a problem hiding this comment.
I wonder if this could use a name that describes what it does rather than what it doesn't do. Perhaps something like container? If a node doesn't have a functional/interactive role, it still pays the role to contain and position its children, if any.
There was a problem hiding this comment.
I find container to be a confusing name in this case. especially if it is used as an leaf node.
| /// | ||
| /// Uses aria tab role to convey this semantic information to the element. | ||
| /// | ||
| /// Screen-readers takes advantage of "aria-label" to describe the visual. |
There was a problem hiding this comment.
Is it a guarantee that "aria-label" will be used? label_and_value.dart may use one of three representations for a label. All representations work with screen readers but they have their own nuances.
Maybe here we should talk about SemanticsObject.label instead of aria-label?
There was a problem hiding this comment.
I copied this from other SemanticsRole. I thought this is describing the use of LabelRepresentation.ariaLabel ?
chunhtai
force-pushed
the
issues/157824
branch
from
6d793fe to
8114e68
Compare
| kTab = 1, | ||
| kTabBar = 2, | ||
| kTabPanel = 3, | ||
| }; |
There was a problem hiding this comment.
I assume a C version of this change will also need to be added embedder.h?
There was a problem hiding this comment.
I will do that in a separate pr when i add the support to the desktop embedding. I am trying to avoid adding support for all platforms in a single pr
3 participants
framework flutter/flutter#158023
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.